Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipelines Cleanup #254

Merged
merged 18 commits into from
Dec 23, 2024
Merged

Pipelines Cleanup #254

merged 18 commits into from
Dec 23, 2024

Conversation

damonbayer
Copy link
Collaborator

@damonbayer damonbayer commented Dec 17, 2024 •
edited
Loading

Closes #253.

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 19.70%. Comparing base (e7758c9) to head (2ae0df3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pipelines/forecast_state.py 0.00% 9 Missing ⚠️
pipelines/fit_pyrenew_model.py 0.00% 1 Missing ⚠️
pipelines/generate_predictive.py 0.00% 1 Missing ⚠️
pipelines/hubverse_create_observed_data_tables.py 0.00% 1 Missing ⚠️
pipelines/prep_eval_data.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   19.44%   19.70%   +0.25%     
==========================================
  Files          21       20       -1     
  Lines        1373     1355      -18     
==========================================
  Hits          267      267              
+ Misses       1106     1088      -18
Flag Coverage Δ
hewr 56.89% <ø> (ø)
pipelines 0.00% <0.00%> (ø)
pyrenew_hew 1.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damonbayer
Copy link
Collaborator Author

This is working locally but broken on azure.

@damonbayer damonbayer marked this pull request as ready for review December 23, 2024 16:21
@damonbayer damonbayer changed the title (Draft) Pipelines Cleanup Pipelines Cleanup Dec 23, 2024
@damonbayer
Copy link
Collaborator Author

I could not get this to work in azure, so I have reduced the scope to simple file renames.

@dylanhmorris dylanhmorris merged commit 0c8d012 into main Dec 23, 2024
14 of 15 checks passed
@dylanhmorris dylanhmorris deleted the dmb_pipelines_cleanup branch December 23, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanhmorris dylanhmorris dylanhmorris approved these changes

@sbidari sbidari Awaiting requested review from sbidari sbidari is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipelines Cleanup
2 participants
@damonbayer @dylanhmorris